feat(docker): use SAM_DOCKER_API_VERSION to control docker api version#8454
Merged
Conversation
roger-zhangg
force-pushed
the
docker_envvar
branch
from
November 21, 2025 00:28
7194bed to
7603b3c
Compare
valerena
previously approved these changes
Nov 21, 2025
valerena
left a comment
valerena
left a comment
Contributor
There was a problem hiding this comment.
typo in the PR title "docer api version". Please fix before/when merging.
roger-zhangg
changed the title
roger-zhangg
enabled auto-merge
November 21, 2025 17:46
bnusunny
requested changes
Nov 21, 2025
bnusunny
approved these changes
Nov 21, 2025
seshubaws
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
if docker API version
1.35&1.44all doest work in certain scenario, the user can't use SAM CLI's docker feature until we release a fix.Why is this change necessary?
this PR provides an escape hatch to use envvar
SAM_DOCKER_API_VERSIONto set a working docker API until we release a new fix.How does it address the issue?
SAM_DOCKER_API_VERSION=1.51 sam build -uto force using 1.51 as docker API versionWhat side effects does this change have?
potentially SAM_DOCKER_API_VERSION could have a conflicting use, but this is very unlikely
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.